This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] Unnecessary restore of timeout global at end of gdb.base/completion.exp


Hello,

This patch removes some code in gdb.base/compilation.exp which
is aimed at restoring the original timeout global value after having
changed it for this testcase. Restoring the timeout global is not
necessary as this is taken care of by gdb_init, which is called
at the start of each testing.

gdb/ChangeLog:

        * gdb.base/completion.exp: Remove code aimed at restoring TIMEOUT.

Tested on x86_64-linux.  I will push by end of week if there are
no objections.

Thank you!
-- 
Joel

---
 gdb/testsuite/gdb.base/completion.exp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gdb/testsuite/gdb.base/completion.exp b/gdb/testsuite/gdb.base/completion.exp
index 2608309..2a85df5 100644
--- a/gdb/testsuite/gdb.base/completion.exp
+++ b/gdb/testsuite/gdb.base/completion.exp
@@ -66,7 +66,6 @@ if ![runto_main] then {
         perror "tests suppressed"
 }
 
-set oldtimeout1 $timeout
 set timeout 30
 
 gdb_test_no_output "complete print values\[0\].x." \
@@ -747,7 +746,4 @@ gdb_test_multiple "" "$test" {
     }
 }
 
-# Restore globals modified in this test...
-set timeout $oldtimeout1
-
 return 0
-- 
1.9.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]