This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add comment for mi_run_cmd_full
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 22 May 2014 10:30:44 -0700
- Subject: Re: [PATCH] Add comment for mi_run_cmd_full
- Authentication-results: sourceware.org; auth=none
- References: <1400708905-14184-1-git-send-email-simon dot marchi at ericsson dot com> <20140521222611 dot GQ22822 at adacore dot com> <537E325D dot 4050908 at ericsson dot com>
> > If I may suggest a different approach (anyone is welcome to comment
> > on that too), it'd be useful to succintly say what the function does
> > first, before getting into the details of the parameters. Also, I would
> > group the semantics of each value of use_mi_command together. So,
> > one example:
> >
> > # Send the command to run the test program.
> > #
> > # If USE_MI_COMMAND is true, the "-exec-run" command is used.
> > # Otherwise, the "run" (CLI) command is used.
> > #
> > # ARGS is passed as argument to the command used to run the test program.
> > # Beware that arguments to "-exec-run" do not have the same semantics as
> > # arguments to the "run" command, so USE_MI_COMMAND influences the meaning
> > # of ARGS. If USE_MI_COMMAND is true, they are arguments to -exec-run.
> > # If USE_MI_COMMAND is false, they are effectively arguments passed
> > # to the test program.
> >
> > I hope it helps!
>
> I think this is very clear. Should I post an updated patch ?
Sure! :). Watchout for the missing second space after a period
in the second to last line.
--
Joel