This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Based on the feedback I have splitted the patch and the following is the patch for Add slr and shr regs support. [Patch, microblaze]: Add slr and shr regs ChangeLog: 2014-05-20 Ajit Agarwal <ajitkum@xilinx.com> * gdb/gdbserver/Makefile.in (microblaze-linux.c): New rule. * gdb/microblaze-tdep.c (microblaze_register_names): Added the rshr and rslr register names. * gdb/microblaze-tdep.h (microblaze_reg_num): Addition of field MICROBLAZE_SLR_REGNUM and MICROBLAZE_SHR_REGNUM. (microblaze_frame_cache): Change in the index of register_offsets. * gdb/regformats/reg-microblaze.dat: New Register data file. Signed-off-by:Ajit Agarwal ajitkum@xilinx.com Thanks & Regards Ajit -----Original Message----- From: Ajit Kumar Agarwal Sent: Wednesday, May 21, 2014 6:25 PM To: 'Michael Eager'; Michael Eager; gdb-patches@sourceware.org; Joel Brobecker Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala Subject: RE: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint -----Original Message----- From: Michael Eager [mailto:eager@eagerm.com] Sent: Wednesday, May 21, 2014 1:18 PM To: Ajit Kumar Agarwal; Michael Eager; gdb-patches@sourceware.org; Joel Brobecker Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add slr and shr regs and little-endian breakpoint On 05/20/14 23:20, Ajit Kumar Agarwal wrote: > > > On 05/20/14 09:25, Ajit Kumar Agarwal wrote: >> Hello Joel: >> >> I have split the patches as you have recommended and the following is the first of the patch. >> >> [Patch, microblaze]: Add slr and shr regs and little-endian >> breakpoint > >>> What is the relationship between adding slr/shr registers and little-endian breapoints? > > The shr/slr registers and little endian breakpoints are related as it > fixed the common problem of Packet Transfer error when connecting to the target remote host through tar remote in gdb for microblaze. >>>What "common" problem? How do either of these changes related to a packet transfer error? Here is the problem description. The problem is related to process_g_packet where the buf_len > 2 * rsa->sizeof_g_packet and throwing the Error that 'g' packet message reply is too long. This is because the buf_len calculated in the init_remote_state function for microblaze target is based On the sizeof_g_packet and remote_packet_size and the memory_packet_config->size. The sizeof_g_packet is 236 because the number of reg num is 59 and 2* sizeof_g_packet comes to 472 .With shr and shl entry and the buf_len is 472. This does not match the greater than conditional statement and works fine. Without shr and shl entry,the sizeof_g_packets comes to 57*4 *2 = 456. This doesn't match the criteria in the process_g_packet function leading to throwing of error message as " 'g' packet message reply is too long". This is happening when tar remote machine:1234 command is run in gdb. >>>These changes don't appear related. Split independent changes in to separate patches. I will split the changes and send the separate patch with shr and shl reg changes and the little endian breakpoint support. Thanks & Regards Ajit -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
Attachment:
0001-Patch-microblaze-Add-slr-and-shr-regs.patch
Description: 0001-Patch-microblaze-Add-slr-and-shr-regs.patch
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |