This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2] Demangler crash handler
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Andrew Burgess <aburgess at broadcom dot com>, gdb-patches at sourceware dot org
- Date: Thu, 15 May 2014 17:01:42 +0100
- Subject: Re: [PATCH 0/2] Demangler crash handler
- Authentication-results: sourceware.org; auth=none
- References: <20140509100656 dot GA4760 at blade dot nx> <201405091120 dot s49BKO1f010622 at glazunov dot sibelius dot xs4all dot nl> <87fvkhjqvs dot fsf at mid dot deneb dot enyo dot de> <53737737 dot 2030901 at redhat dot com> <5373950D dot 7050903 at broadcom dot com> <5373B6C6 dot 6060401 at redhat dot com> <20140515132527 dot GD13323 at blade dot nx>
On 05/15/2014 02:25 PM, Gary Benson wrote:
> It's not clear to me what benefit a second system for early
> termination would add, or how you would decide which system
> to use for any given error.
Just to cross this off for the record. The idea would be to use
early termination for bad input, and d_assert for asserting
internal consistency is sane. Much like in GDB we don't use
gdb_assert for bad input.
But better coverage/testing beats this by a wide margin,
in my book.
Speaking of coverage, I wonder what gcov says...
--
Pedro Alves