This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.
- From: Doug Evans <dje at google dot com>
- To: David Blaikie <dblaikie at gmail dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, keiths at redhat dot com
- Date: Wed, 23 Apr 2014 15:46:26 -0700
- Subject: Re: [patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.
- Authentication-results: sourceware.org; auth=none
- References: <CAENS6EuYXbEkbaiUG3DLYxJmysy_rF_VPBhb09==f_F8MExthQ at mail dot gmail dot com>
David Blaikie writes:
> gdb.cp/impl-this.exp is testing the ability to scope names within a
> class and includes cases where the base class was specified via a
> typedef.
>
> Due to GCC's PR14819 these tests weren't actually testing this case -
> GCC produces the same debug info regardless of whether there's a
> typedef used in the base specifier.
>
> Clang correctly produces the typedef debug info for the base type and
> exposes a variety of failures/limitations in these test cases.
>
> The attached patch updates the tests to flag these cases as
> unsupported under GCC and xfail as appropriate under Clang.
> commit 7fa92f9a15f440129dd5a989511f3bbda646afa5
> Author: David Blaikie <dblaikie@gmail.com>
> Date: Sun Apr 13 11:15:44 2014 -0700
>
> Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.
>
> gdb/testsuite/
> * gdb.cp/impl-this.exp: Mark several tests XFAIL/UNSUPPORTED due to
> PR16841 and GCC PR60833
There are several calls to setup_kfail passing gdb/x and gdb/y.
x and y need to be fixed.
According to gdb/testsuite/README I think (!) setup_xfail should
be used here instead of setup_kfail, since the problem originates
with gcc.
kfail = known gdb problem
xfail = known environment problem (e.g. compiler)
Ok with those changes.
[Though I can well imagine I'm missing something.
This part of the testsuite and c++ is a bit beyond me.]