This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/12] Iterate over 'struct varobj_item' instead of PyObject
- From: Keith Seitz <keiths at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Wed, 23 Apr 2014 12:28:54 -0700
- Subject: Re: [PATCH 03/12] Iterate over 'struct varobj_item' instead of PyObject
- Authentication-results: sourceware.org; auth=none
- References: <1392367471-13527-1-git-send-email-yao at codesourcery dot com> <1392367471-13527-4-git-send-email-yao at codesourcery dot com>
On 02/14/2014 12:44 AM, Yao Qi wrote:
V2:
- Call varobj_delete_iter in free_variable.
- Fix changelog entries.
- Use XNEW.
gdb:
2014-02-14 Pedro Alves <pedro@codesourcery.com>
Yao Qi <yao@codesourcery.com>
* python/py-varobj.c (py_varobj_iter_next): Move some code
from varobj.c.
* varobj-iter.h (struct varobj_item): Moved from varobj.c.
* varobj.c: Move "varobj-iter.h" inclusion earlier.
(struct varobj_item): Moved to varobj-iter.h".
(varobj_clear_saved_item): New function.
(update_dynamic_varobj_children): Move python-related code to
py-varobj.c.
(free_variable): Call varobj_clear_saved_item and
varobj_iter_delete.
This looks okay to me. I recommend a maintainer give this a final review.
Keith