This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 7/9] Remove Guile mark functions that don't mark anything


On Sat 12 Apr 2014 21:29, Doug Evans <xdje42@gmail.com> writes:

> Andy Wingo <wingo@igalia.com> writes:
>
>> * gdb/guile/scm-arch.c (arscm_mark_arch_smob):
>> * gdb/guile/scm-block.c (bkscm_mark_block_smob)
>>   (bkscm_mark_block_syms_progress_smob):
>> * gdb/guile/scm-frame.c (frscm_mark_frame_smob):
>> * gdb/guile/scm-lazy-string.c (arscm_mark_arch_smob):
>> * gdb/guile/scm-symbol.c (lsscm_mark_lazy_string_smob):
>> * gdb/guile/scm-symtab.c (syscm_mark_symbol_smob):
>> * gdb/guile/scm-type.c (tyscm_mark_type_smob): Remove useless mark
>>   functions.
>> ---
>>  gdb/guile/scm-arch.c        |  9 ---------
>>  gdb/guile/scm-block.c       | 19 -------------------
>>  gdb/guile/scm-frame.c       |  9 ---------
>>  gdb/guile/scm-lazy-string.c |  9 ---------
>>  gdb/guile/scm-symbol.c      |  9 ---------
>>  gdb/guile/scm-symtab.c      |  9 ---------
>>  gdb/guile/scm-type.c        |  9 ---------
>>  7 files changed, 73 deletions(-)
>
> This is ok with the requisite changelog entry corrections.
>
> These functions were useful during early development, but I guess we're
> passed that point now.

Just FYI, mark functions are actively harmful, and should be avoided if
possible.  They slow down allocation, slow down GC, and, more
importantly, are very tricky to write correctly.  See:

  https://lists.gnu.org/archive/html/guile-user/2011-11/msg00069.html

Regards,

Andy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]