This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][PATCH] Allow JIT unwinder provide symbol information
- From: Doug Evans <dje at google dot com>
- To: Alexander Smundak <asmundak at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 11 Apr 2014 11:47:05 -0700
- Subject: Re: [RFC][PATCH] Allow JIT unwinder provide symbol information
- Authentication-results: sourceware.org; auth=none
- References: <20131226183618 dot D264CA18A0 at sasha2 dot mtv dot corp dot google dot com> <21204 dot 13416 dot 607204 dot 485255 at ruffy dot mtv dot corp dot google dot com> <CAHQ51u6Hd3+B78RUK5rTh49nqvFgt_o1x6f=sePPZVDEo1ueTA at mail dot gmail dot com> <CADPb22Qithfi41fs1Ax5tz_g-zf8pzPRWKbnBrJZCiSqrO=KuA at mail dot gmail dot com> <CADPb22Rf5jpi_YCF5UE13=CUmUV-FNZHPSpfbmpO3KNQq1sKfQ at mail dot gmail dot com> <CAHQ51u7ZzfLQp2NH15FzM-pGM+rOyczeAZc2nH-+XS175gTmyw at mail dot gmail dot com>
Alexander Smundak writes:
> diff --git a/gdb/jit-reader.in b/gdb/jit-reader.in
> index 6e2ee64..a6a0ab1 100644
> --- a/gdb/jit-reader.in
> +++ b/gdb/jit-reader.in
> @@ -336,6 +413,7 @@ struct gdb_reader_funcs
> gdb_read_debug_info *read;
> gdb_unwind_frame *unwind;
> gdb_get_frame_id *get_frame_id;
> + gdb_get_symbol_attr *get_symbol_attr;
> gdb_destroy_reader *destroy;
> };
>
Hi.
I think the easiest thing to do to preserve version 1 support would be to reorganize this to:
@@ -336,6 +413,7 @@ struct gdb_reader_funcs
gdb_read_debug_info *read;
gdb_unwind_frame *unwind;
gdb_get_frame_id *get_frame_id;
gdb_destroy_reader *destroy;
+ gdb_get_symbol_attr *get_symbol_attr;
};
and then have the code that dereferences get_symbol_attr first check that the interface is version 2.
Can you do that?
And any needed doc updates.
And then with that I think(!) we can finally check this in.