This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [testsuite] Set target-charset to ascii
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 10 Apr 2014 06:07:00 -0700
- Subject: Re: [PATCH] [testsuite] Set target-charset to ascii
- Authentication-results: sourceware.org; auth=none
- References: <1395711550-29273-1-git-send-email-yao at codesourcery dot com> <533A23CE dot 8040905 at codesourcery dot com> <534607F5 dot 5010105 at codesourcery dot com>
Sorry about the wait, Yao.
> >> gdb/testsuite:
> >>
> >> 2014-03-25 Yao Qi <yao@codesourcery.com>
> >>
> >> * lib/gdb.exp (with_target_charset): New proc.
> >> * gdb.base/printcmds.exp (test_print_all_chars): Wrap tests with
> >> with_target_charset.
> >> (test_print_strings): Likewise.
> >> (test_repeat_bytes): Likewise.
> >> * gdb.base/setvar.exp: Set target-charset to ASCII temporarily
> >> for some tests.
I'm a little unsure about this one, because I am not sure that all
targets will support the "ASCII" charset. For instance, I logged on
a Tru64 machine, and "local -a" only returned:
POSIX
en_US.ISO8859-1
On the other hand, a GDB built with libiconv supports ASCII (and much
more). So I'm inclined to try your patch. Give it another couple of
days, and if noone objects, then go ahead and commit.
--
Joel