This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5 7/8] Validate symbol file using build-id


Hi Eli,

On Thu, 20 Mar 2014 04:51:40 +0100, Eli Zaretskii wrote:
> Thanks.  I already approved the docs parts, right?

there remains unapproved the doc/gdb.texinfo part of this patch 7/8.
In this v5 series the text has been even changed due to the functionality
change:
 * svr4_validate() considers missing local build-id as not-a-match
(*)

Unfinished discussion with you about this doc/gdb.texinfo part is:
	https://sourceware.org/ml/gdb-patches/2014-03/msg00473.html
	Message-ID: <20140319223258.GA5398@host2.jankratochvil.net>


Thanks,
Jan


(*) Originally I wanted to check it in mostly as Aleksandar wrote it with
    various additions done possibly incrementally later.
    But given how complicated is to settle down on the messages and
    documentation of a part which was wrong (**) anyway I have decided to fix
    it rather all already during this first check-in.

(**) wrong as not a regression but imperfect functionality.
     I have found from practical using of non-upstreamed Fedora build-id
     patches that it is never right to load non-build-id file for build-id
     targer, in Fedora it is patch (not equivalent but similar functionality):
     http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-buildid-locate-solib-missing-ids.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]