This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence
- From: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>
- To: 'Joel Brobecker' <brobecker at adacore dot com>
- Cc: "tromey at redhat dot com" <tromey at redhat dot com>, "Boell, Keven" <keven dot boell at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 19 Mar 2014 15:31:07 +0000
- Subject: RE: [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence
- Authentication-results: sourceware.org; auth=none
- References: <1391704056-25246-1-git-send-email-sanimir dot agovic at intel dot com> <1391704056-25246-10-git-send-email-sanimir dot agovic at intel dot com> <20140228170941 dot GB16479 at adacore dot com> <20140313160055 dot GI4882 at adacore dot com>
Thanks for your review.
> I see. It took me a while to understand what you are saying, but
> I do, now. It's one of these situations where it's almost a shame
> that some case branches return, while others don't, and fallback
> on something that happens to take care of dynamicity. Oh well, I have
> no better proposal at the moment, so the current approach is fine
> with me.
>
> Question for you: Shouldn't we be doing the same for LOC_CONST?
>
Good catch, indeed we should. I have updated the patch to cover
LOC_CONST and added a test-case as well. Thanks again.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052