This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR


> 2014-03-18  Pierre Langlois  <pierre.langlois@embecosm.com>
> 
>       * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small
>         stack allocation.

Now that Tristan approved the patch, do you have an FSF copyright
assignment on file? This patch is small that we can push it in without;
but if you are planning on sending more, you'll need one. Just let me
know and I will get you a message to get you started (it takes a while
to complete, so the sooner the better).

One remark on the ChangeLog; the formatting is off a bit. It should be
indented by one tab, and the indentation should be the same, regardless
of whether the line starts with a '*' or not - no extra indentation
for continuation lines. Thus:

	* avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small
	stack allocation.

(in emails, it's not important to be using 8 spaces or 1 tab, but in
the CL, we tend to be picky about it).

Thanks!
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]