This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] gdb.exp: Support absolute path name args in 'prepare_for_testing' etc.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: arnez at linux dot vnet dot ibm dot com (Andreas Arnez)
- Cc: gdb-patches at sourceware dot org, krebbel at linux dot vnet dot ibm dot com (Andreas Krebbel)
- Date: Wed, 12 Mar 2014 13:57:09 +0100 (CET)
- Subject: Re: [PATCH 1/4] gdb.exp: Support absolute path name args in 'prepare_for_testing' etc.
- Authentication-results: sourceware.org; auth=none
Andreas Arnez wrote:
> On Tue, Mar 11 2014, Ulrich Weigand wrote:
> > However, for consistency, I think you should also support absolute
> > path names in the gdb_compile_shlib[_pthreads] path just next to
> > the location you're modifying.
>
> OK, good point. Done.
>
> BTW, is any test case using the shlib[_pthreads] option with
> build_executable_from_specs at all?
Not many, it seems; support was added for gdb.threads/dlopen-libpthread.exp.
> > Otherwise this looks good to me.
>
> Thanks. With the updated patch below, is the patch set then OK to
> apply?
Yes, this is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com