This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR16508


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2014-02-15  Yao Qi  <yao@codesourcery.com>
Yao> 	PR breakpoints/16508
Yao> 	* tracepoint.c (check_trace_running): New function.
Yao> 	(trace_find_command): Move code to check_trace_running and
Yao> 	call check_trace_running.
Yao> 	(trace_find_pc_command): Likewise.
Yao> 	(trace_find_tracepoint_command): Likewise.
Yao> 	(trace_find_line_command): Likewise.
Yao> 	(trace_find_range_command): Likewise.
Yao> 	* tracepoint.h (check_trace_running): Likewise.
Yao> 	* mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.

One trivial nit here.

Yao> +if [prepare_for_testing $expfile $executable $srcfile \
Yao> +	[list debug]] {
Yao> +    untested "failed to prepare for trace tests"

prepare calls untested for you, so no need to do it again.

Ok with this change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]