This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR16508
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 05 Mar 2014 13:03:36 -0700
- Subject: Re: [PATCH] Fix PR16508
- Authentication-results: sourceware.org; auth=none
- References: <1392447370-22318-1-git-send-email-yao at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2014-02-15 Yao Qi <yao@codesourcery.com>
Yao> PR breakpoints/16508
Yao> * tracepoint.c (check_trace_running): New function.
Yao> (trace_find_command): Move code to check_trace_running and
Yao> call check_trace_running.
Yao> (trace_find_pc_command): Likewise.
Yao> (trace_find_tracepoint_command): Likewise.
Yao> (trace_find_line_command): Likewise.
Yao> (trace_find_range_command): Likewise.
Yao> * tracepoint.h (check_trace_running): Likewise.
Yao> * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.
One trivial nit here.
Yao> +if [prepare_for_testing $expfile $executable $srcfile \
Yao> + [list debug]] {
Yao> + untested "failed to prepare for trace tests"
prepare calls untested for you, so no need to do it again.
Ok with this change.
Tom