This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 26 Feb 2014 06:19:01 -0800
- Subject: Re: [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address.
- Authentication-results: sourceware.org; auth=none
- References: <1393360363-5603-1-git-send-email-palves at redhat dot com> <530DEDCD dot 9080207 at redhat dot com>
Hi Pedro,
> gdb/
> 2014-02-26 Pedro Alves <palves@redhat.com>
>
> * breakpoint.c (bpstat_check_breakpoint_conditions): Handle
> task-specific breakpoints.
Interesting bug.
> gdb/testsuite/
> 2014-02-26 Pedro Alves <palves@redhat.com>
>
> * gdb.ada/tasks.exp: Set a task-specific breakpoint at break_me
> that won't ever trigger. Make sure that GDB reports the correct
> breakpoint that caused the stop.
It all looks good to me. Just a few nits I happen to notice:
> +# Insert a breakpoint that should stop only if task 1 stops. Since
> +# task 1 never calls break_me, this shouldn't actually ever trigger.
> +# The fact this this breakpoint is created _before_ the next one
^^^^^^^^^
that this?
> +# matter. GDB used to have a bug where it would report the first
^^^^^^
matters
Thank you,
--
Joel