This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/DWARF] Add array DW_AT_bit_stride and DW_AT_byte_stride support


On Fri, 2014-02-21 at 10:31 +0100, Joel Brobecker wrote:
> > Personally I would have just added the new argument and fixed up all
> > callers, just so I had an overview of all the callers that might
> have a
> > bit_stride concept that could be added.
> 
> I briefely considered this idea, but since most uses seem to be
> creating arrays where the context suggested that bit-strides was
> not relevant, I went for the dual approach; it also reduces the patch
> size with noise from updating all calls (~30 of them). That being
> said,
> if people prefer your suggestion, it can certainly be done easily.

I think your approach is fine. For someone who already knows the code
base and knows the stride of an array is an odd concept in most cases
anyway. I would just have done it because I am unfamiliar with the code
base, so it would have given me an opportunity to go through it all
because the compiler would yell at me and made me inspect and understand
it all.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]