This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] value.c (record_latest_value): Fix comment.


Hi.

This patch fixes a comment that was found to be wrong in this thread:

https://sourceware.org/ml/gdb-patches/2014-02/msg00674.html

I checked as far back as 6.1.1, and it's never returned -1.
[I could go back further, but I don't see the point.]

2014-02-20  Doug Evans  <dje@google.com>

	* value.c (record_latest_value): Fix comment.

diff --git a/gdb/value.c b/gdb/value.c
index 73ba18e..50b0245 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1642,9 +1642,7 @@ set_value_component_location (struct value *component,
 /* Access to the value history.  */
 
 /* Record a new value in the value history.
-   Returns the absolute history index of the entry.
-   Result of -1 indicates the value was not saved; otherwise it is the
-   value history index of this new item.  */
+   Returns the absolute history index of the entry.  */
 
 int
 record_latest_value (struct value *val)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]