This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 6/8] Use new to_xfer_partial interface in ctf and tfile target
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Feb 2014 13:18:24 +0000
- Subject: Re: [PATCH 6/8] Use new to_xfer_partial interface in ctf and tfile target
- Authentication-results: sourceware.org; auth=none
- References: <1392185152-21220-1-git-send-email-yao at codesourcery dot com> <1392185152-21220-7-git-send-email-yao at codesourcery dot com>
On 02/12/2014 06:05 AM, Yao Qi wrote:
> +/* Read from mappable read-only sections of BFD executable files.
> + Similar to exec_read_only_xfer_partial, but return
> + TARGET_XFER_E_UNAVAILABLE is data is unavailable. */
Typo: s/is data/if data/
> +
> +extern enum target_xfer_status
> + section_table_xfer_available_memory (gdb_byte *readbuf, ULONGEST offset,
> + ULONGEST len, ULONGEST *xfered_len);
The comment on function names I made on a previous patch applies here too.
This only reads, so instead:
extern enum target_xfer_status
section_table_read_available_memory (gdb_byte *readbuf, ULONGEST offset,
ULONGEST len, ULONGEST *xfered_len);
or:
extern enum target_xfer_status
section_table_read_partial_available_memory (gdb_byte *readbuf,
ULONGEST offset,
ULONGEST len,
ULONGEST *xfered_len);
--
Pedro Alves