This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/8] Use new to_xfer_partial interface in ctf and tfile target


On 02/12/2014 06:05 AM, Yao Qi wrote:
> +/* Read from mappable read-only sections of BFD executable files.
> +   Similar to exec_read_only_xfer_partial, but return
> +   TARGET_XFER_E_UNAVAILABLE is data is unavailable.  */

Typo: s/is data/if data/

> +
> +extern enum target_xfer_status
> +  section_table_xfer_available_memory (gdb_byte *readbuf, ULONGEST offset,
> +				       ULONGEST len, ULONGEST *xfered_len);

The comment on function names I made on a previous patch applies here too.

This only reads, so instead:

extern enum target_xfer_status
  section_table_read_available_memory (gdb_byte *readbuf, ULONGEST offset,
			               ULONGEST len, ULONGEST *xfered_len);

or:

extern enum target_xfer_status
  section_table_read_partial_available_memory (gdb_byte *readbuf,
					       ULONGEST offset,
				               ULONGEST len,
					       ULONGEST *xfered_len);

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]