This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Implement completion limiting
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 12 Feb 2014 21:41:50 +0000
- Subject: Re: [PATCH 2/2] Implement completion limiting
- Authentication-results: sourceware.org; auth=none
- References: <20140212115548 dot GA2866 at blade dot nx> <20140212115759 dot GC2866 at blade dot nx> <52FBA428 dot 4020404 at redhat dot com> <819294975 dot 3055298 dot 1392238425291 dot JavaMail dot zimbra at redhat dot com>
On 02/12/2014 08:53 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> On 02/12/2014 11:57 AM, Gary Benson wrote:
>>> +@smallexample
>>> +(@value{GDBP}) b @key{TAB}@key{TAB}
>>> +Too many possibilities.
>>> +@end smallexample
>>> +
>>
>> Does the user lose the edit line after that, or can he
>> continue typing the command?
>
> You can continue typing, nothing is lost.
Like this?
@smallexample
(@value{GDBP}) b @key{TAB}@key{TAB}
Too many possibilities.
+ (@value{GDBP}) b
@end smallexample
Could you add that extra line to the example to make
that obvious in the docs?
>> I'd also suggest saying "completion candidates" instead of
>> "possibilities". Sounds more accurate / less vague to me.
>> (here and elsewhere in the docs and inline help as well)
>
> The reason I chose that as the message is to match up with
> readline's own messages:
>
> $ ls
> Display all 140 possibilities? (y or n)
>
> I'd prefer to keep "Too many possibilities" for consistency
Thanks, I agree, makes sense.
--
Pedro Alves