This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Implement completion limiting
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 12 Feb 2014 18:27:05 +0200
- Subject: Re: [PATCH 2/2] Implement completion limiting
- Authentication-results: sourceware.org; auth=none
- References: <20140212115548 dot GA2866 at blade dot nx> <20140212115759 dot GC2866 at blade dot nx>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 12 Feb 2014 11:57:59 +0000
> From: Gary Benson <gbenson@redhat.com>
>
> This patch adds a new exception, TOO_MANY_COMPLETIONS_ERROR, to be
> thrown whenever the completer has generated too many possibilities to
> be useful. A new user-settable variable, "max_completions", is added
> to control this behaviour.
Thanks.
> +void
> +_initialize_completer (void)
> +{
> + add_setshow_zuinteger_unlimited_cmd ("max-completions", no_class,
> + &max_completions, _("\
> +Set maximum number of line completion possibilities."), _("\
> +Show maximum number of line completion possibilities."), _("\
> +Use this to limit the number of possibilities considered\n\
> +during line completion. Specifying \"unlimited\" or -1\n\
> +disables limiting. Note that setting either no limit or\n\
> +a very large limit can cause pauses during completion."),
Why do you use "line completion"? I think it can only confuse users.
How about
Set maximum number of completion candidates to show.
instead?
Other than that, OK for the documentation part, but please also
provide a NEWS entry for this new functionality.