This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] cleanup: remove declared variables without any references
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: sanimir dot agovic at intel dot com, gdb-patches at sourceware dot org
- Date: Wed, 12 Feb 2014 11:58:36 +0100 (CET)
- Subject: Re: [PATCH] cleanup: remove declared variables without any references
- Authentication-results: sourceware.org; auth=none
- References: <1392126951-25347-1-git-send-email-sanimir dot agovic at intel dot com> <201402111412 dot s1BECWEX000161 at glazunov dot sibelius dot xs4all dot nl> <20140212033234 dot GQ5485 at adacore dot com>
> Date: Wed, 12 Feb 2014 07:32:34 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> > The mipsnbsd-tdep.c one is not ok. For one thing, you're leaving
> > behind the comment describing the code. But I think this is better
> > left alone, as somebody might want to add (or put back) the missing
> > glue that uses those bits.
>
> Hey Mark! The problem with leaving them behind is that they cause
> a build failure when building the HEAD, I think, because we build
> with -Werror. Can we find a way to avoid that? For instance, could
> we #if zero the code?
Probably best to do something like that. Ideally a NetBSd devloper
would step in and fix things...