Re: [PATCH 1/2] nios2-tdep: set default frame base

[Sandra Loosemore <sandra at codesourcery dot com>]

On 02/11/2014 06:20 PM, Yao Qi wrote:
> On 02/11/2014 05:26 PM, Sanimir Agovic wrote:
> > @@ -1595,6 +1595,7 @@ nios2_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
> >     dwarf2_append_unwinders (gdbarch);
> >     frame_unwind_append_unwinder (gdbarch, &nios2_stub_frame_unwind);
> >     frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
> > +  frame_base_set_default (gdbarch, &nios2_stub_frame_base);
>
> Sanimir,
> some lines below, we have:
>
>    frame_unwind_append_unwinder (gdbarch, &nios2_frame_unwind);
>
>    /* Single stepping.  */
>    set_gdbarch_software_single_step (gdbarch, nios2_software_single_step);
>
>    /* Hook in ABI-specific overrides, if they have been registered.  */
>    gdbarch_init_osabi (info, gdbarch);
>
>    if (tdep->jb_pc >= 0)
>      set_gdbarch_get_longjmp_target (gdbarch, nios2_get_longjmp_target);
>
>    frame_base_set_default (gdbarch, &nios2_frame_base);
>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> so looks we can remove nios2_stub_frame_base.

Removing the unused variable looks like the most conservatively correct 
fix to me, too.

Sanimir, thank you for finding this buglet.  :-)

-Sandra