This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 1/2] link gdbserver against libiberty
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Fri, 07 Feb 2014 16:32:07 +0000
- Subject: Re: [RFC 1/2] link gdbserver against libiberty
- Authentication-results: sourceware.org; auth=none
- References: <1390243792-31176-1-git-send-email-tromey at redhat dot com> <1390243792-31176-2-git-send-email-tromey at redhat dot com> <52DDD1BA dot 7050202 at codesourcery dot com> <87y51n0yh4 dot fsf at fleche dot redhat dot com>
On 02/07/2014 02:49 PM, Tom Tromey wrote:
> Yao> ... and I don't understand why do we remove AR and AR_FLAGS from
> Yao> FLAGS_TO_PASS.
>
> I don't remember any more, either.
> I restored them and rebuilt and it all worked fine.
> I did discover that my earlier patch had broken "make install"; fixed in
> this version.
This looks good to me. Thanks for doing this.
> -SUBDIRS = $(GNULIB_BUILDDIR)
> +SUBDIRS = $(GNULIB_BUILDDIR) $(LIBIBERTY_BUILDDIR)
> CLEANDIRS = $(SUBDIRS)
> +INSTALLDIRS = $(GNULIB_BUILDDIR)
I understand making sure we don't try to install anything from
libiberty. Preexisting to this patch, but I wonder why we even
run make install in gnulib. Seems that like with libiberty,
we wouldn't ever want to install anything built in gnulib
subdir.
--
Pedro Alves