This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 3/9] don't let bin2hex call strlen
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 05 Feb 2014 20:36:48 +0000
- Subject: Re: [RFC 3/9] don't let bin2hex call strlen
- Authentication-results: sourceware.org; auth=none
- References: <1390245501-1186-1-git-send-email-tromey at redhat dot com> <1390245501-1186-4-git-send-email-tromey at redhat dot com>
On 01/20/2014 07:18 PM, Tom Tromey wrote:
> Currently bin2hex may call strlen if the length argument is zero.
> This prevents some function unification; and also it seems cleaner to
> me not to have a special meaning for a zero length.
>
> 2014-01-20 Tom Tromey <tromey@redhat.com>
>
> * common/rsp-low.c (bin2hex): Never take strlen of argument.
> * remote.c (extended_remote_run, remote_rcmd)
> (remote_download_trace_state_variable, remote_save_trace_data)
> (remote_set_trace_notes): Update.
> * tracepoint.c (encode_source_string, tfile_write_status)
> (tfile_write_uploaded_tsv): Update.
OK.
--
Pedro Alves