This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Change len's type to ULONGEST: remote_write_bytes_aux
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 23 Jan 2014 14:37:32 +0000
- Subject: Re: [PATCH] Change len's type to ULONGEST: remote_write_bytes_aux
- Authentication-results: sourceware.org; auth=none
- References: <1390395379-6992-1-git-send-email-yao at codesourcery dot com>
On 01/22/2014 12:56 PM, Yao Qi wrote:
> AFAICS, the target layer is a boundary. In one side, we pass size_t
> or ssize_t to target related APIs, and in the other side, the
> implementation side, we used LONGEST (ULONGEST in latest code) because
> of to_xfer_partial.
>
> Since remote_write_bytes_aux and remote_write_bytes belong to the
> implementation of remote target, we should use ULONGEST for len, IMO.
>
> Regression tested on x86_64-linux. Is it OK?
This is fine with me.
--
Pedro Alves