This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/11] Use varobj_is_dynamic_p more widely


On 11/23/2013 06:09 PM, Yao Qi wrote:
Use varobj_is_dynamic_p more widely so that the callers of
varobj_is_dynamic_p are unchanged when we add available-children-only
stuff in varobj_is_dynamic_p.

This also looks good to me.

Keith


gdb:

2013-11-24  Yao Qi  <yao@codesourcery.com>

	* varobj.c (varobj_get_num_children): Call
	varobj_is_dynamic_p.
	(varobj_list_children): Likewise.
	(varobj_update): Likewise.  Update comments.
---
  gdb/varobj.c |   11 +++++------
  1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/gdb/varobj.c b/gdb/varobj.c
index 948f80c..0e0be6c 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -895,7 +895,7 @@ varobj_get_num_children (struct varobj *var)
  {
    if (var->num_children == -1)
      {
-      if (var->dynamic->pretty_printer != NULL)
+      if (varobj_is_dynamic_p (var))
  	{
  	  int dummy;

@@ -922,7 +922,7 @@ varobj_list_children (struct varobj *var, int *from, int *to)

    var->dynamic->children_requested = 1;

-  if (var->dynamic->pretty_printer != NULL)
+  if (varobj_is_dynamic_p (var))
      {
        /* This, in theory, can result in the number of children changing without
  	 frontend noticing.  But well, calling -var-list-children on the same
@@ -1715,10 +1715,9 @@ varobj_update (struct varobj **varp, int explicit)
  	    }
  	}

-      /* We probably should not get children of a varobj that has a
-	 pretty-printer, but for which -var-list-children was never
-	 invoked.  */
-      if (v->dynamic->pretty_printer != NULL)
+      /* We probably should not get children of a dynamic varobj, but
+	 for which -var-list-children was never invoked.  */
+      if (varobj_is_dynamic_p (v))
  	{
  	  VEC (varobj_p) *changed = 0, *type_changed = 0, *unchanged = 0;
  	  VEC (varobj_p) *new = 0;



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]