This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] gdbserver debug_printf+timestamps: FUNCTION_NAME
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 17 Jan 2014 12:46:22 +0000
- Subject: Re: [PATCH 1/3] gdbserver debug_printf+timestamps: FUNCTION_NAME
- Authentication-results: sourceware.org; auth=none
- References: <yjt2zjnztait dot fsf at ruffy dot mtv dot corp dot google dot com> <52B1842F dot 5020401 at redhat dot com> <21205 dot 55987 dot 69477 dot 892571 at ruffy dot mtv dot corp dot google dot com> <52D81569 dot 3080006 at redhat dot com> <CADPb22SK=YQeOcOdNPXERxXKOT2E64k=pHhw0GBiLj4LQhL-Ag at mail dot gmail dot com> <52D82AD5 dot 7000306 at redhat dot com> <21208 dot 27400 dot 695984 dot 88504 at ruffy dot mtv dot corp dot google dot com> <21208 dot 27605 dot 74231 dot 313332 at ruffy dot mtv dot corp dot google dot com>
On 01/16/2014 11:31 PM, Doug Evans wrote:
> Doug Evans writes:
> > v2 is now split into three parts:
> >
> > 1/3 - move ASSERT_FUNCTION to FUNCTION_NAME in common-utils.h
> > 2/3 - create new function delim_string_to_char_ptr_vec_append in gdb_vecs.c
> > 3/3 - the actual debug_printf patch
> >
> > I went with --debug[=timestamp] as the option naming.
>
> I didn't do a darwin build but the change is mechanical.
>
> 2014-01-16 Doug Evans <dje@google.com>
>
> * common/common-utils.h (FUNCTION_NAME): Renamed from ASSERT_FUNCTION,
> and moved here ...
> * common/gdb_assert.h (ASSERT_FUNCTION): ... from here.
> #include "common-utils.h".
> (gdb_assert, gdb_assert_fail, gdb_assert_not_reached): Update.
> * common/vec.h (VEC_ASSERT_PASS): Update.
> * darwin-nat.h: Replace #include of gdb_assert.h with common-utils.h.
> (MACH_CHECK_ERROR): Update.
Looks good to me.
Thanks,
--
Pedro Alves