This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 12/32] Add target_ops argument to to_thread_name
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 Jan 2014 17:50:27 +0000
- Subject: Re: [RFC 12/32] Add target_ops argument to to_thread_name
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com> <1389640367-5571-13-git-send-email-tromey at redhat dot com> <52D53599 dot 4040503 at redhat dot com> <87fvopry6x dot fsf at fleche dot redhat dot com>
On 01/15/2014 04:45 PM, Tom Tromey wrote:
> Pedro> The patch is fine with me as is, but I'll note that I don't
> Pedro> think there's any need for exec_set_find_memory_regions
> Pedro> nowadays. Seems to me that exec_ops.to_find_memory_regions could
> Pedro> always be set to objfile_find_memory_regions unconditionally.
>
> Good point.
>
> Here is a patch I've added to my branch to fix this up.
> It's cleaner and also more obviously correct in the multi-target case.
Thanks. Looks good to me.
--
Pedro Alves