Re: [PATCH] Regression setting breakpoint

[Sergio Durigan Junior <sergiodj at redhat dot com>]

On Wednesday, December 11 2013, Michael Eager wrote:

> From 6e6a7110f950e3d90978637b21fcb913934be9b1 Mon Sep 17 00:00:00 2001
> From: Michael Eager <eager@eagercon.com>
> Date: Tue, 10 Dec 2013 11:50:27 -0800
> Subject: [PATCH] Fix regression symbol name different from linkage name.
>
> gdb:
> *  dwarf2read.c (die_needs_namespace): Do nothing for C language.
>
> testsuite:
> *  gdb.base/break-linker-symname.c: New.
> *  gdb.base/break-linker-symname.exp: New.

Not really a code review, but the ChangeLog entries should be of the
form:

2014-01-16  Your Name  <you@email.com>

	* file.c (function): What changed.

Also...

> diff --git a/gdb/testsuite/gdb.base/break-linker-symname.exp b/gdb/testsuite/gdb.base/break-linker-symname.exp
> new file mode 100644
> index 0000000..2a86f37
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/break-linker-symname.exp
> @@ -0,0 +1,25 @@
> +#   Copyright 2013 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# Test that 'set breakpoint always-inserted 1' is not a brick
> +# Also verifies that breakpoint enabling/disabling works properly
> +# with duplicated breakpoints.
> +
> +if { [prepare_for_testing break-linker-symname.exp break-linker-symname break-linker-symname.c] } {
> +    return -1
> +}

You can rewrite this part as:

-----
  standard_testfile

  if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
    return -1
  }
-----

Thanks,

-- 
Sergio