Re: [PATCH 3/3] psymtab.c cleanup: remove "partial" from function names

[Doug Evans <dje at google dot com>]

Doug Evans writes:
 > Doug Evans writes:
 >  > Hi.
 >  > 
 >  > This last patch removes "partial" from the names of
 >  > expand_partial_symbol_names and map_partial_symbol_filenames.
 >  > It also renames expand_partial_symbol_names to match the
 >  > struct quick_symbol_functions "method" that it wraps:
 >  > expand_symtabs_matching.
 >  > 
 >  > This patch also adds two parameters to expand_symtabs_matching
 >  > so that it can fully wrap the underlying quick_symbol_functions method.
 >  > This makes it usable in more places.
 >  > I thought of having a cover function that still had the same
 >  > signature as the old expand_partial_symbol_names function,
 >  > but I couldn't think of a good name, and it wasn't clear it was
 >  > worth it anyway.
 >  > 
 >  > 2013-12-06  Doug Evans  <dje@google.com>
 >  > 
 >  > 	* symfile.h (expand_symtabs_matching): Renamed from
 >  > 	expand_partial_symbol_names.  Update prototype.
 >  > 	(map_symbol_filenames): Renamed from map_partial_symbol_filenames.
 >  > 	* symfile.c (expand_symtabs_matching): Renamed from
 >  > 	expand_partial_symbol_names.  New args file_matcher, kind.
 >  > 	Rename arg fun to symbol_matcher.
 >  > 	(map_symbol_filenames): Renamed from map_partial_symbol_filenames.
 >  > 	* ada-lang.c (ada_make_symbol_completion_list): Update to call
 >  > 	expand_symtabs_matching.
 >  > 	(ada_add_global_exceptions): Call expand_symtabs_matching.
 >  > 	* mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update to
 >  > 	call map_symbol_filenames.
 >  > 	* symtab.c (sources_info): Update to call map_symbol_filenames.
 >  > 	(search_symbols): Call expand_symtabs_matching.
 >  > 	(default_make_symbol_completion_list_break_on): Update to call
 >  > 	expand_symtabs_matching.
 >  > 	(make_source_files_completion_list): Update to call
 >  > 	map_symbol_filenames.
 > 
 > Hi.
 > I missed a few instances of expand_partial_symbol_names.
 > Revised patch attached.
 > 
 > 2013-12-06  Doug Evans  <dje@google.com>
 > 
 > 	* symfile.h (expand_symtabs_matching): Renamed from
 > 	expand_partial_symbol_names.  Update prototype.
 > 	(map_symbol_filenames): Renamed from map_partial_symbol_filenames.
 > 	* symfile.c (expand_symtabs_matching): Renamed from
 > 	expand_partial_symbol_names.  New args file_matcher, kind.
 > 	Rename arg fun to symbol_matcher.
 > 	(map_symbol_filenames): Renamed from map_partial_symbol_filenames.
 > 	* ada-lang.c (ada_complete_symbol_matcher): Renamed from
 > 	ada_expand_partial_symbol_name.
 > 	(ada_make_symbol_completion_list): Update to call
 > 	expand_symtabs_matching.
 > 	(ada_add_global_exceptions): Call expand_symtabs_matching.
 > 	* mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update to
 > 	call map_symbol_filenames.
 > 	* symtab.c (sources_info): Update to call map_symbol_filenames.
 > 	(search_symbols): Call expand_symtabs_matching.
 > 	(symbol_completion_matcher): Renamed from expand_partial_symbol_name.
 > 	(default_make_symbol_completion_list_break_on): Update to call
 > 	expand_symtabs_matching.
 > 	(make_source_files_completion_list): Update to call
 > 	map_symbol_filenames.

I have committed this.