Re: [RFC 04/32] add make-target-delegates

[Pedro Alves <palves at redhat dot com>]

On 01/13/2014 07:12 PM, Tom Tromey wrote:
> This patch adds a new script, call make-target-delegates, which
> auto-generates some target delegation code based on annotations in
> target.h.  This adds the new delegation macros, the new generated
> file, and adds the necessary calls to the new generated functions to
> target.c.  It doesn't, however, add any actual annotations to the
> target methods, leaving these for separate patches.
> 
> 2014-01-08  Tom Tromey  <tromey@redhat.com>
> 

Maybe add the PR number to this one.

> 	* target-delegates.c: New file.
> 	* target.c: Include target-delegates.c.
> 	(init_dummy_target): Call install_dummy_methods.
> 	(complete_target_initialization): Call install_delegators.
> 	* target.h (TARGET_DEFAULT_IGNORE, TARGET_DEFAULT_NORETURN)
> 	(TARGET_DEFAULT_RETURN, TARGET_DEFAULT_FUNC): New defines.
> 	* make-target-delegates: New file.

Looks quite nice to me.

> ---
>  gdb/ChangeLog             |  10 ++
>  gdb/make-target-delegates | 253 ++++++++++++++++++++++++++++++++++++++++++++++
>  gdb/target-delegates.c    |  14 +++
>  gdb/target.c              |   9 ++
>  gdb/target.h              |  24 +++++
>  5 files changed, 310 insertions(+)
>  create mode 100755 gdb/make-target-delegates
>  create mode 100644 gdb/target-delegates.c
> 
> diff --git a/gdb/make-target-delegates b/gdb/make-target-delegates
> new file mode 100755
> index 0000000..47f960c
> --- /dev/null
> +++ b/gdb/make-target-delegates
> @@ -0,0 +1,253 @@
> +#!/usr/bin/perl
> +
> +# Copyright (C) 2013 Free Software Foundation, Inc.

2013-2014

-- 
Pedro Alves