This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] PR python/15464 and python/16113


>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Tom> I think this approach will fail in the situation where multiple
Tom> anonymous sub-objects appear at the same bitpos.  I think this happens
Tom> with inheritance, typically at bitpos 0 but perhaps elsewhere with
Tom> multiple inheritance.

My example here was totally wrong -- the Field iterator doesn't recurse
into superclasses, so conflicts of the sort I was imagining can't occur.
This seems like a reasonable spot to extend the API someday.

Luckily you found a way to interpret my comment that actually made sense :)

Siva> 2014-12-07  Siva Chandra Reddy  <sivachandra@google.com>

Pessimistic date :)

Siva>         PR python/15464
Siva>         PR python/16133

I think it is PR python/16113, not 16133.

This patch is ok with those two nits fixed.

thanks,
Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]