This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] PR python/15464 and python/16113
- From: Tom Tromey <tromey at redhat dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 13 Jan 2014 14:12:39 -0700
- Subject: Re: [Patch] PR python/15464 and python/16113
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gyT_vfZaFPSbBMVn5oZ+awqzEiMXGD5-ffowDdWMPv3uA at mail dot gmail dot com> <CAGyQ6gwgsCuOu_bSVVWumcVKPs3fyB41KS-QDgCafQggpWBHgg at mail dot gmail dot com> <87lhysltqs dot fsf at fleche dot redhat dot com> <CAGyQ6gzuY0Wd4sXb48L2ZCFsP5MCskWPOwxqLAeQNvvoMdacKQ at mail dot gmail dot com>
>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
Tom> I think this approach will fail in the situation where multiple
Tom> anonymous sub-objects appear at the same bitpos. I think this happens
Tom> with inheritance, typically at bitpos 0 but perhaps elsewhere with
Tom> multiple inheritance.
My example here was totally wrong -- the Field iterator doesn't recurse
into superclasses, so conflicts of the sort I was imagining can't occur.
This seems like a reasonable spot to extend the API someday.
Luckily you found a way to interpret my comment that actually made sense :)
Siva> 2014-12-07 Siva Chandra Reddy <sivachandra@google.com>
Pessimistic date :)
Siva> PR python/15464
Siva> PR python/16133
I think it is PR python/16113, not 16133.
This patch is ok with those two nits fixed.
thanks,
Tom