This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Split i386_stap_parse_special_token into smaller functions
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Mark Kettenis <kettenis at gnu dot org>
- Date: Fri, 10 Jan 2014 23:52:22 -0200
- Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions
- Authentication-results: sourceware.org; auth=none
- References: <m37gaodxg2 dot fsf at redhat dot com> <20131230031112 dot GC6055 at adacore dot com> <m361px3yzr dot fsf at redhat dot com>
On Monday, January 06 2014, I wrote:
> On Monday, December 30 2014, Joel Brobecker wrote:
>
>>> As requested by Joel on:
>>>
>>> <https://sourceware.org/ml/gdb-patches/2013-12/msg00977.html>
>>>
>>> I am reposting this separate patch whose only purpose is to split
>>> i386_stap_parse_special_token into smaller functions. I haven't
>>> modified anything logical in the functions, i.e., there's still one
>>> latent bug on i386_stap_parse_special_token_triplet now. I will soon
>>> post a patch to fix this, and to also improve the readability of the two
>>> new functions.
>>>
>>> I am also posting the output of "git diff -b" here.
>>
>> Thank you, Sergio. This patch is missing a ChangeLog :).
>>
>> FWIW, this patch looks good to me, and it is IMO a nice improvement
>> over the current state. But i386-tdep.c is usually under Mark's
>> responsibility, so let's give him a little bit of time to reply
>> as well.
>
> Ping.
Ping^2.
This patch is pretty simple IMO (just code movement), so maybe it could
be reviewed by some other maintainer and maybe approved? It's holding a
fix for a bug :-).
Thanks,
--
Sergio