This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] Implement D primitive types in GDB
- From: Tom Tromey <tromey at redhat dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jan 2014 14:18:25 -0700
- Subject: Re: [PATCH 4/5] Implement D primitive types in GDB
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+c9Sogq3jp+SzXWcg3_QdNE1u_+6sY=AFT-dSH+dpoTUA at mail dot gmail dot com> <87sisx80oo dot fsf at fleche dot redhat dot com> <CABOHX+ev=xWQsjh0CavYTP0Bu2F-UkRjvBMjaf+6XyiZG_RFaQ at mail dot gmail dot com>
>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:
Iain> Comments duly noted and rebased patch. Though I have a feeling you
Iain> may ask to comment non-static functions in their declared headers. :)
That's like the one thing gdb doesn't have a pedantic standard for.
Yet :) At some point Stan will presumably push in his doxygen change
and then we'll start converting to that.
Iain> +/* Mapping of all D basic data types into the language vector. */
Iain> +enum d_primitive_types {
Space between the comment and the definition.
Yeah, that pedantic.
Iain> + d_primitive_type_cent, /* signed 128 bit integer */
Comments have to start with an upper-case letter and end with a period
and two spaces.
Iain> +/* Implements the la_language_arch_info language_defn routine
Iain> + for language D. */
Iain> +static void
Blank line here and elsewhere.
This is ok with those nits fixed.
Tom