This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 09/29] record-btrace: start counting at one
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: jan dot kratochvil at redhat dot com, palves at redhat dot com, gdb-patches at sourceware dot org
- Date: Thu, 19 Dec 2013 19:27:41 +0200
- Subject: Re: [PATCH v9 09/29] record-btrace: start counting at one
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-10-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 19 Dec 2013 17:44:39 +0100
>
> The record instruction-history and record-function-call-history commands start
> counting instructions at zero. This is somewhat unintuitive when we start
> navigating in the recorded instruction history. Start at one, instead.
>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> 2013-12-19 Markus Metzger <markus.t.metzger@intel.com>
>
> * btrace.c (ftrace_new_function): Start counting at one.
>
> testsuite/
> * gdb.btrace/instruction_history.exp: Update.
> * gdb.btrace/function_call_history.exp: Update.
>
>
> ---
> gdb/NEWS | 4 +
> gdb/btrace.c | 8 +-
> gdb/record-btrace.c | 4 +-
> gdb/testsuite/gdb.btrace/function_call_history.exp | 156 ++++++++++-----------
> gdb/testsuite/gdb.btrace/instruction_history.exp | 67 ++++-----
> 5 files changed, 125 insertions(+), 114 deletions(-)
OK for the NEWS part.
Thanks.