This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Improve and fix catch-syscall.exp
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 18 Dec 2013 20:25:50 -0200
- Subject: Re: [PATCH] Improve and fix catch-syscall.exp
- Authentication-results: sourceware.org; auth=none
- References: <m37gb85p2o dot fsf at redhat dot com> <m3a9g27yr8 dot fsf at sspiff dot org> <m38uvkxuiy dot fsf at redhat dot com> <52B02635 dot 2090405 at redhat dot com> <m338lrwfbm dot fsf at redhat dot com> <CAP9bCMREgYYoBMh6EaSDBrg8xsVHCu0hkF7hFK6_oA4L+s2h9A at mail dot gmail dot com>
On Wednesday, December 18 2013, Doug Evans wrote:
> Two nits. Ok with the changes below.
>
>> @@ -428,47 +391,35 @@ proc do_syscall_tests_without_xml {} {
>>
>> # This procedure fills the vector "all_syscalls_numbers" with the proper
>> # numbers for the used syscalls according to the architecture.
>> +#
>> +# These numbers were taken from the respective <asm/unistd.h> files
>> +# from each architecture.
>
> This comment can go (no longer needed).
>
>>
>> -gdb_exit
>> -set do_xml_test ![gdb_skip_xml_test]
>> -gdb_start
>> -gdb_reinitialize_dir $srcdir/$subdir
>> -gdb_load ${binfile}
>> +# Filling all the syscalls numbers before starting anything.
>
> s/Filling/Fill/
Fixed all nits. Thank you and Pedro for the review. Checked-in:
<https://sourceware.org/ml/gdb-cvs/2013-12/msg00097.html>
--
Sergio