Re: [RFA-v2] Fix PR 16201: internal error on a cygwin program linked against a DLL with no .data section

[Joel Brobecker <brobecker at adacore dot com>]

> 2013-12-13  Pierre Muller  <muller@sourceware.org>
> 
>         Fix PR16201.
>         coff-pe-read.c (read_pe_exported_syms): Set OBJFILE->sect_index_XXX
>         for XXX text, data or bss to any section that sets ms_type
>         field of section_data to mst_XXX, with preference
>         to canonical names '.text', '.data' and '.bss'.

It's been a month since you posted the patch, and no one but me really
commented on it. Since we need this before branching for 7.7, and
since I do not see anything obviously wrong with it, I will give it
the OK. Let's wait until Friday to commit, in order to give anyone
else a last chance to comment, but otherwise, my only request is that
you expand the comment you added to explain __why__ you set the various
sect_index_XXX fields, especially since you do it even when already set.
Only nit-picking request is also that it would be nice if the comment
was formatted so that line lengths would be closer to 70 - while most
people tend to write lines that are too long, you seem to be to the
opposite :).

Thank you!

> diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
> index 91ee3f6..ec9aed5 100644
> --- a/gdb/coff-pe-read.c
> +++ b/gdb/coff-pe-read.c
> @@ -466,6 +466,15 @@ read_pe_exported_syms (struct objfile *objfile)
>         {
>           section_data[sectix].rva_start = vaddr;
>           section_data[sectix].rva_end = vaddr + vsize;
> +         /* For .text, .data and .bss section
> +             set corresponding sect_index_XXX,
> +             even if it was already set before.  */
> +         if (sectix == PE_SECTION_INDEX_TEXT)
> +           objfile->sect_index_text = sectix;
> +         if (sectix == PE_SECTION_INDEX_DATA)
> +           objfile->sect_index_data = sectix;
> +         if (sectix == PE_SECTION_INDEX_BSS)
> +           objfile->sect_index_bss = sectix;
>         }
>        else
>         {
> @@ -480,11 +489,23 @@ read_pe_exported_syms (struct objfile *objfile)
>           section_data[otherix].rva_end = vaddr + vsize;
>           section_data[otherix].vma_offset = 0;
>           if (characteristics & IMAGE_SCN_CNT_CODE)
> -           section_data[otherix].ms_type = mst_text;
> +           {
> +             section_data[otherix].ms_type = mst_text;
> +             if (objfile->sect_index_text == -1)
> +               objfile->sect_index_text = otherix;
> +           }
>           else if (characteristics & IMAGE_SCN_CNT_INITIALIZED_DATA)
> -           section_data[otherix].ms_type = mst_data;
> +           {
> +             section_data[otherix].ms_type = mst_data;
> +             if (objfile->sect_index_data == -1)
> +             objfile->sect_index_data = otherix;
> +           }
>           else if (characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA)
> -           section_data[otherix].ms_type = mst_bss;
> +           {
> +             section_data[otherix].ms_type = mst_bss;
> +             if (objfile->sect_index_bss == -1)
> +               objfile->sect_index_bss = otherix;
> +           }
>           else
>             section_data[otherix].ms_type = mst_unknown;
>           otherix++;

-- 
Joel