This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v8 22/24] btrace, gdbserver: read branch trace incrementally
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "jan dot kratochvil at redhat dot com" <jan dot kratochvil at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 16 Dec 2013 19:23:35 +0000
- Subject: Re: [patch v8 22/24] btrace, gdbserver: read branch trace incrementally
- Authentication-results: sourceware.org; auth=none
- References: <1386839747-8860-1-git-send-email-markus dot t dot metzger at intel dot com> <1386839747-8860-23-git-send-email-markus dot t dot metzger at intel dot com> <52AB640F dot 6050201 at redhat dot com> <A78C989F6D9628469189715575E55B230AA38CEE at IRSMSX104 dot ger dot corp dot intel dot com>
On 12/16/2013 12:45 PM, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: Pedro Alves [mailto:palves@redhat.com]
>> Sent: Friday, December 13, 2013 8:46 PM
>> To: Metzger, Markus T
>
>
>>> + /* The instructions vector may become empty temporarily if this has
>>> + been the only instruction in this function segment.
>>> + This violates the invariant but will be remedied shortly. */
>>
>> By what?
>
> By btrace_compute_ftrace when we add the new trace.
>
> I added the above to the comment.
Excellent, thanks.
--
Pedro Alves