This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/Patch v3] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 12 Dec 2013 22:11:31 +0200
- Subject: Re: [RFC/Patch v3] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gyj2rJqpZmNwSpfNiCovAEf6_P_gZvhs8iyf1-DOEOGbQ at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Wed, 11 Dec 2013 15:23:36 -0800
> From: Siva Chandra <sivachandra@google.com>
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -40,6 +40,8 @@
> ** Frame filters and frame decorators have been added.
> ** Temporary breakpoints are now supported.
> ** Line tables representation has been added.
> + ** New attribute 'parent_type' for gdb.Field objects.
> + ** gdb.Field objects can be used as subscripts on gdb.Value objects.
OK.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -23985,7 +23985,17 @@ can access its @code{foo} element with:
> bar = some_val['foo']
> @end smallexample
>
> -Again, @code{bar} will also be a @code{gdb.Value} object.
> +@cindex getting structure elements using gdb.Field objects as subscripts
> +Again, @code{bar} will also be a @code{gdb.Value} object. Structure
> +elements can also be accessed by using @code{gdb.Field} objects as
> +subscripts (@xref{Types In Python} for more information on
^
Please use @pxref here, and add a comma after the closing brace, as
indicated. Cross-references should have a comma, a period, or (in the
case of @pxref) a closing parenthesis after their closing brace.
OK with that change.
Thanks.