This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v7 22/24] btrace, gdbserver: read branch trace incrementally
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Thu, 12 Dec 2013 10:12:54 +0100
- Subject: Re: [patch v7 22/24] btrace, gdbserver: read branch trace incrementally
- Authentication-results: sourceware.org; auth=none
- References: <1385735899-12481-1-git-send-email-markus dot t dot metzger at intel dot com> <1385735899-12481-23-git-send-email-markus dot t dot metzger at intel dot com> <20131211195820 dot GB22687 at host2 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B230AA3655F at IRSMSX104 dot ger dot corp dot intel dot com>
On Thu, 12 Dec 2013 09:23:46 +0100, Metzger, Markus T wrote:
> What this function does is stitch the old and new trace together by inserting
> the last instruction of the old trace as beginning of the chronologically first
> block of the new trace. Then it removes the last instruction from the old
> trace - it will be re-added when we process the new trace.
>
> I renamed the variables as follows:
> end -> last_bfun
> insn -> last_insn
> block -> first_new_block
Yes, I find those names helpful.
Thanks,
Jan