This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Hui Zhu <hui_zhu at mentor dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Wed, 11 Dec 2013 08:40:09 -0800
- Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet
- Authentication-results: sourceware.org; auth=none
- References: <5265022F dot 8060203 at mentor dot com> <52654A2C dot 9010202 at redhat dot com> <529707C7 dot 4040504 at mentor dot com> <5298AE7C dot 6020607 at redhat dot com> <529C80D2 dot 2080608 at mentor dot com> <529C9B42 dot 20600 at redhat dot com> <529D62F7 dot 80701 at mentor dot com> <52A22582 dot 8040509 at redhat dot com> <52A40015 dot 207 at mentor dot com> <52A61E86 dot 3020005 at redhat dot com> <m31u1lvimb dot fsf at sspiff dot org> <52A750AA dot 1080807 at redhat dot com>
On Tue, Dec 10, 2013 at 9:34 AM, Pedro Alves <palves@redhat.com> wrote:
>> Doug wrote:
>> If we must change things, I would prefer having a predicate
>> and call that first.
>
> I can try that. Does your script API series already have
> something like that? I'd guess it's probably touching this
> code too.
Hi. I read this one after the actual patch. No worries.
> Yeah, the previous post was just an RFC, I didn't mean to apply
> all of it as a single commit. In this case, there are two
> implementations of that function (the real one, and then
> the dummy one for when Python isn't configured in), but
> only of them is documented, and I needed to document the
> return code, which affects the dummy version too. Moving
> to the header sorted that out. BTW, I realize this is
> probably conflicting with your scripts API series. ISTR
> that removes the dummy functions anyway, right? In any
> case, I'll try the predicate way.
Fortunately I anticipated the patch and included a change in my updated series.
It'll need some tweaks if UNSUPPORTED_ERROR is removed but easy enough.