This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/Patch] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 09 Dec 2013 05:50:09 +0200
- Subject: Re: [RFC/Patch] PR 16113: Allow gdb.Field objects as subscripts on gdb.Value objects
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gxKWjkXGA9FXZL=_HfpBDF0q9c5vCyGq3R4nn2VnPWh0A at mail dot gmail dot com> <CAGyQ6gyxMSf7kp940ts-B8BSRewDh9ke+0HheDS-8zkXa79Row at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Sun, 8 Dec 2013 17:04:16 -0800
> From: Siva Chandra <sivachandra@google.com>
>
> 2013-12-08 Siva Chandra Reddy <sivachandra@google.com>
>
> PR 16113: Allow gdb.Field objects with the subscript operator on
> gdb.Value objects of struct/class values.
> * NEWS (Python Scripting): Add entry for the new feature.
> * python/py-type.c (gdbpy_is_field): New function
> * python/py-value.c (valpy_getitem): Allow subscript value to be
> a gdb.Field object.
> (value_has_field): New function
> (get_field_flag): New function
> * python/python-internal.h (gdbpy_is_field): Add declaration.
>
> testsuite/
> * gdb.python/py-value-cc.cc: Improve test case.
> * gdb.python/py-value-cc.exp: Add new tests.
>
> doc/
> * gdb.texinfo (Values From Inferior): Add a note about using
> gdb.Field objects as subscripts on gdb.Value objects.
OK for the documentation parts, but please consider adding an index
entry in the manual for the new feature.
Thanks.