This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] skip_prolgoue (amd64)
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Tue, 03 Dec 2013 18:28:03 +0000
- Subject: Re: [PATCH 2/3] skip_prolgoue (amd64)
- Authentication-results: sourceware.org; auth=none
- References: <1385735051-27558-1-git-send-email-yao at codesourcery dot com> <1385735051-27558-3-git-send-email-yao at codesourcery dot com> <201311291436 dot rATEaZ5Z030292 at glazunov dot sibelius dot xs4all dot nl> <201311291605 dot rATG5XVb030184 at glazunov dot sibelius dot xs4all dot nl> <52994E79 dot 4000004 at codesourcery dot com> <5299B9D0 dot 2020304 at redhat dot com> <529C37A2 dot 9000207 at codesourcery dot com>
On 12/02/2013 07:32 AM, Yao Qi wrote:
> On 11/30/2013 06:11 PM, Pedro Alves wrote:
>> I'm thinking we might need to flush the dcache before handling each
>> event, like we already invalidate the overlay cache (see
>> "overlay_cache_invalid = 1" in infrun.c) ?
>
> I don't know why overlay cache is flushed in each event. Doing some
> archaeology doesn't give me any clue. I doubt that the overly may
> change between any two events. It (flushing overlay cache) looks not
> necessary to me, at least, when overlay events breakpoint is enabled.
Even with overlay events breakpoint enabled, I'd think we'd want to
be careful to not hit the previous cache even _while_ handling
the overlay breakpoint event. Also, with multi-threading, the
overlay breakpoint event may trigger at the same time as some
other event in another thread, and we may end up handling
the other event first.
--
Pedro Alves