This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] skip_prolgoue (amd64)
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: mark dot kettenis at xs4all dot nl
- Cc: yao at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Fri, 29 Nov 2013 17:05:33 +0100 (CET)
- Subject: Re: [PATCH 2/3] skip_prolgoue (amd64)
- Authentication-results: sourceware.org; auth=none
- References: <1385735051-27558-1-git-send-email-yao at codesourcery dot com> <1385735051-27558-3-git-send-email-yao at codesourcery dot com> <201311291436 dot rATEaZ5Z030292 at glazunov dot sibelius dot xs4all dot nl>
> Date: Fri, 29 Nov 2013 15:36:36 +0100 (CET)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
>
> > From: Yao Qi <yao@codesourcery.com>
> > Date: Fri, 29 Nov 2013 22:24:10 +0800
> >
> > gdb:
> >
> > 2013-11-29 Yao Qi <yao@codesourcery.com>
> >
> > * amd64-tdep.c (amd64_analyze_stack_align): Call
> > target_read_code instead of target_read_memory.
> > (amd64_analyze_prologue): Call read_code_unsigned_integer
> > instead of read_memory_unsigned_integer. Call read_code
> > instead of read_memory.
> > (amd64_skip_xmm_prologue): Likewise.
>
> Makes sense to me.
But only if the cache is properly invalidated when control when
running/stepping. Is it?