This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

Am 11/25/2013 4:18 PM, schrieb Mark Kettenis:
From: "Tedeschi, Walfred" <>
Date: Mon, 25 Nov 2013 14:56:59 +0000

Hello Mark,

Ok, I Will let it symmetrical to the AVX, i.e:

/* In case one of the MPX XCR0 bits is set we consider we have MPX.
  #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_MPX
Still doesn't do what it says on the tin.  The macro is checking if
*both* bits are set.  If you want to have the code match the comment
it needs to be changed to something like:

#define HAS_MPX(XRC0) (((XRC0) & I386_XSTATE_MPX) != 0)

or you need to change the comment to state that all bits need to be set.
Hello Mark,

What you proposed is better.
I will incorporate your feedback and Pedro's feedback and resend it.

Thanks your review and feedback!
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]