This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
- From: Doug Evans <xdje42 at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Stan Shebs <stanshebs at earthlink dot net>, gdb-patches at sourceware dot org
- Date: Sun, 17 Nov 2013 09:58:55 -0800
- Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
- Authentication-results: sourceware.org; auth=none
- References: <CAA8o+=Q2ur7dAZYRRgOeRV1=KW_2azOwRY8meVHYKaOx3Yh9GQ at mail dot gmail dot com> <527AB482 dot 80600 at earthlink dot net> <87ppqd1a0t dot fsf at fleche dot redhat dot com> <m3li10bsbj dot fsf at seba dot sebabeach dot org> <87r4asz3be dot fsf at fleche dot redhat dot com> <CAA8o+=T2a8WLE8zi1NO=u8B460KmwOvA2m2pzVJCkAsXw6vHBw at mail dot gmail dot com> <CAA8o+=RBU=AkLmW=Q+J16jZgJZ-Fpp8nPajK-FDH-AyrEJgQyQ at mail dot gmail dot com> <CAA8o+=RLzeC6o8X2ZBsc_HGq_aJAUYVGuyWJe49No9UcyAS4yA at mail dot gmail dot com> <m34n7lbbb9 dot fsf at seba dot sebabeach dot org> <CAP9bCMQa7g0vupyHKwmZKum1QJDToDL7bCj92Sc6xbV9R71KGg at mail dot gmail dot com>
On Thu, Nov 14, 2013 at 9:24 AM, Doug Evans <xdje42@gmail.com> wrote:
> On Sat, Nov 9, 2013 at 11:54 AM, Doug Evans <xdje42@gmail.com> wrote:
>> Ok, no more attachment.
>>
>> 2013-11-09 Doug Evans <xdje42@gmail.com>
>>
>> * gdbtypes.c: #include bcache.h, dwarf2loc.h.
>> (type_equality_entry): Move here from python/py-type.c.
>> (type_equality_entry_d): Ditto.
>> (compare_maybe_null_strings, check_types_equal): Ditto.
>> (check_types_worklist, types_deeply_equal): Ditto.
>> * gdbtypes.h (types_deeply_equal): Declare.
>> * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h.
>> (typy_richcompare): Update.
>
> Ping.
Since this is just a simple cleanup, there's no real need to put
someone to the trouble of doing a code review so I think I'm just
going to check this in.
Guess I should have just submitted it that way in the first place.
Good thing to know for next time.