This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] use error, not internal_error, in dwarf2-frame.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 14 Nov 2013 13:48:02 +0400
- Subject: Re: [PATCH] use error, not internal_error, in dwarf2-frame.c
- Authentication-results: sourceware.org; auth=none
- References: <1384375392-32110-1-git-send-email-tromey at redhat dot com>
> I think that gdb should not call internal_error for bad DWARF.
> Instead, it should simply throw an ordinary exception.
FWIW, I agree with the reasoning.
> 2013-11-13 Tom Tromey <tromey@redhat.com>
>
> * dwarf2-frame.c (execute_cfa_program, dwarf2_compile_cfa_to_ax)
> (dwarf2_frame_cache, dwarf2_frame_prev_register)
> (encoding_for_size, read_encoded_value): Use error, not
> internal_error.
--
Joel