This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't evaluate condition for non-matching thread


On 11/13/2013 03:01 AM, Doug Evans wrote:

> Is there a reason the current code is the way it is?

I can't think of any.  I'm actually surprised we do this.

We'd get the same effect if/when we push the thread check
down to the target, and I wouldn't imagine this "always eval
condition first" blocking such new feature.

> [I realize conditions can have side-effects, to, e.g., collect data,
> but the user has made the breakpoint thread-specific already.]

Yeah.  There are several other ways to get to same result, so
it's not a real issue, IMO.

> If you think this warrants a NEWS entry I can certainly add one.

I don't think so.

> Ok to check in?

OK.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]