This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.


Hi,
gdb ppc64 build was failing with the following:

gcc -g3 -mminimal-toc  -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber  -I../../gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1  -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o remote-sim.o -MT remote-sim.o -MMD -MP -MF .deps/remote-sim.Tpo ../../gdb/remote-sim.c
../../gdb/remote-sim.c:820: error: conflicting types for âgdbsim_detachâ
../../gdb/remote-sim.c:81: note: previous declaration of âgdbsim_detachâ was here
make[2]: *** [remote-sim.o] Error 1

I've checked in the obvious patch below that fixed the problem.
Thanks,

--
Edjunior

2013-11-11  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* remote-sim.c (gdbsim_detach): Fix prototype.
---
 gdb/ChangeLog    |    4 ++++
 gdb/remote-sim.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index e095035..f7be6fa 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -78,7 +78,7 @@ static void gdbsim_open (char *args, int from_tty);
 
 static void gdbsim_close (void);
 
-static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty);
+static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
 
 static void gdbsim_prepare_to_store (struct regcache *regcache);
 
-- 
1.7.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]