This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
- From: Doug Evans <dje at sebabeach dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Stan Shebs <stanshebs at earthlink dot net>, gdb-patches at sourceware dot org, xdje42 at gmail dot com
- Date: Sat, 9 Nov 2013 11:47:53 -0800
- Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
- Authentication-results: sourceware.org; auth=none
- References: <CAA8o+=Q2ur7dAZYRRgOeRV1=KW_2azOwRY8meVHYKaOx3Yh9GQ at mail dot gmail dot com> <527AB482 dot 80600 at earthlink dot net> <87ppqd1a0t dot fsf at fleche dot redhat dot com> <m3li10bsbj dot fsf at seba dot sebabeach dot org> <87r4asz3be dot fsf at fleche dot redhat dot com> <CAA8o+=T2a8WLE8zi1NO=u8B460KmwOvA2m2pzVJCkAsXw6vHBw at mail dot gmail dot com>
On Thu, Nov 7, 2013 at 8:40 AM, Doug Evans <dje@sebabeach.org> wrote:
> On Thu, Nov 7, 2013 at 6:36 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Doug" == Doug Evans <dje@sebabeach.org> writes:
>>
>> Doug> Tom Tromey <tromey@redhat.com> writes:
>> Stan> +/* A helper function for tyscm_richcompare that checks two types for
>> Stan> + "deep" equality. Returns non-zero if the types are considered the
>> Stan> + same, zero otherwise. */
>>>>
>> Stan> "tyscm_richcompare"? Should that be typy_... ?
>>>>
>>>> It would be helpful if Doug could list all the change he made when
>>>> moving the code.
>>
>> Doug> I don't understand.
>> Doug> Which changes? While useful beyond its present state, this is in
>> Doug> essence just a cleanup.
>>
>> I had thought this patch was more or less a straight move of the code.
>> But Stan's note revealed a change from what is currently in the tree.
>> So the question is, can you say what else changed?
>> That would be handy so I don't have to go over it line-by-line myself.
>
> Ah. Except for the comment (*1) the only substantive change is in the result:
> Py_{NE,EQ} -> 0.1.
>
> (*1): Early on I made a copy because I wasn't sure how things would end up,
> and left in a FIXME to remind myself to revisit.
> I revisited and realized there's no need for the copy, but missed the
> comment. Blech.
> "diff -b before after" shows nothing of note to me.
Here's v2 of the patch.
I fixed the comment and added an assert to check type1,type2 != NULL.
I changed the email address in the ChangeLog entry 'cus I'm having
problems with this domain.
After this email hopefully the switchover is complete.